fix: Android native player trickplay incorrect offsetting#851
Merged
PartyDonut merged 2 commits intoDonutWare:developfrom Mar 18, 2026
Merged
fix: Android native player trickplay incorrect offsetting#851PartyDonut merged 2 commits intoDonutWare:developfrom
PartyDonut merged 2 commits intoDonutWare:developfrom
Conversation
PartyDonut
approved these changes
Mar 18, 2026
Collaborator
PartyDonut
left a comment
There was a problem hiding this comment.
Looks good to me, thanks for fixing this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Due to a maximum texture size set by Coil (4096 pixels in either dimension on my phone), my trickplay tiles were being downscaled to 4096, without the
trickPlayModelknowing about it, causing some incorrect display on the timeline. This PR rescales the display offset and size to match this downscaled bitmap.Also fixed trickplay images being stretched (ugly) when the images are not 16:9, which is true in many movies especially.
Checklist