Skip to content

fix: Android native player trickplay incorrect offsetting#851

Merged
PartyDonut merged 2 commits intoDonutWare:developfrom
matt-hb:fix-exoplayer-trickplay
Mar 18, 2026
Merged

fix: Android native player trickplay incorrect offsetting#851
PartyDonut merged 2 commits intoDonutWare:developfrom
matt-hb:fix-exoplayer-trickplay

Conversation

@matt-hb
Copy link
Copy Markdown
Contributor

@matt-hb matt-hb commented Mar 18, 2026

Pull Request Description

Due to a maximum texture size set by Coil (4096 pixels in either dimension on my phone), my trickplay tiles were being downscaled to 4096, without the trickPlayModel knowing about it, causing some incorrect display on the timeline. This PR rescales the display offset and size to match this downscaled bitmap.

Also fixed trickplay images being stretched (ugly) when the images are not 16:9, which is true in many movies especially.

Checklist

  • If a new package was added, did you ensure it works for all supported platforms? Is the package well maintained
  • Check that any changes are related to the issue at hand.

Copy link
Copy Markdown
Collaborator

@PartyDonut PartyDonut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for fixing this.

@PartyDonut PartyDonut added the bug Something isn't working label Mar 18, 2026
@PartyDonut PartyDonut merged commit cd92a7d into DonutWare:develop Mar 18, 2026
1 check passed
@github-project-automation github-project-automation bot moved this to Done in Fladder Mar 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants