Skip to content

fix: Episodes not showing on mobile#923

Merged
PartyDonut merged 1 commit intoDonutWare:developfrom
schembriaiden:fix/episodes-not-showing-on-mobile
Apr 11, 2026
Merged

fix: Episodes not showing on mobile#923
PartyDonut merged 1 commit intoDonutWare:developfrom
schembriaiden:fix/episodes-not-showing-on-mobile

Conversation

@schembriaiden
Copy link
Copy Markdown
Contributor

Pull Request Description

This pull request updates how the crossAxisCount is calculated in several grid layouts to ensure it always has a valid value and avoids runtime errors. The main change is clamping the crossAxisCount to a minimum of 1, which prevents invalid grid configurations if the value is zero or negative.

Grid layout safety improvements:

  • Updated crossAxisCount calculation in PosterGrid, EpisodeDetailsList, and EditImageContentState to use .clamp(1, double.maxFinite).toInt(), ensuring the count is always at least 1 and preventing crashes from invalid grid sizes.

Issue Being Fixed

Flutter error: 'package:flutter/src/rendering/sliver_grid.dart': Failed assertion: line 359 pos 15: 'crossAxisCount > 0': is not true.

Resolves #858

Screenshots / Recordings

Tested On

  • Android
  • Android TV
  • iOS
  • Linux
  • Windows
  • macOS
  • Web

A test on iOS would also help.

Checklist

  • If a new package was added, did you ensure it works for all supported platforms? Is the package well maintained
  • Check that any changes are related to the issue at hand.

Copy link
Copy Markdown
Collaborator

@PartyDonut PartyDonut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍🏼

@PartyDonut PartyDonut added the bug Something isn't working label Apr 11, 2026
@PartyDonut PartyDonut merged commit 032222a into DonutWare:develop Apr 11, 2026
1 check passed
@github-project-automation github-project-automation bot moved this to Done in Fladder Apr 11, 2026
@schembriaiden schembriaiden deleted the fix/episodes-not-showing-on-mobile branch April 11, 2026 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

🐛 episode page not displaying correctly

2 participants