fix: improve subpath handling in docker#942
Merged
PartyDonut merged 1 commit intoDonutWare:developfrom Apr 12, 2026
Merged
Conversation
2d769cc to
33cd9a5
Compare
33cd9a5 to
f176eb8
Compare
|
Consider an alternative: do not move files. Adjust the nginx configuration instead. That is more in line with other configuration files adjusted when starting a container. |
f176eb8 to
17abe52
Compare
|
Tested from my end. Looks good! Configured the environment variable: Without any workarounds from a reverse proxy running in front, Fladder is successfully served from |
PartyDonut
approved these changes
Apr 12, 2026
Collaborator
PartyDonut
left a comment
There was a problem hiding this comment.
Looks good to me thanks for the quick implementation.
And thanks @Zepmann voor testing it out 👍🏼
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
This pull request improves the Docker setup and entrypoint logic for the Fladder web application, focusing on better handling of custom web paths and permissions. The main changes involve normalizing and applying the
FLADDER_WEBPATHvariable more robustly, dynamically generating the Nginx configuration based on the deployment context, and ensuring correct file ownership for Nginx.Entrypoint and Nginx configuration improvements:
docker-entrypoint.shscript now normalizes theFLADDER_WEBPATHvariable, ensuring it always starts and ends with a single slash, and updates the<base href>inindex.htmlaccordingly./etc/nginx/conf.d/default.confdepending on whether Fladder is served at the root or a subpath, and selects the correct port based on the user (root or rootless).File and directory permissions:
DockerfileandDockerfile-rootlessnow ensure that/usr/share/nginx/htmland/etc/nginx/conf.dare owned by thenginxuser, preventing permission issues at runtime.docker-entrypoint.shscript is explicitly set tonginx:nginxin the rootless Dockerfile for consistency.Issue Being Fixed
Resolves #917 (reply in thread)
Screenshots / Recordings
Tested On
Checklist