Enhance VectorStore filtering with debug logging and update similarit…#126
Merged
Enhance VectorStore filtering with debug logging and update similarit…#126
Conversation
…y validation This commit improves the filtering logic in the VectorStore class by adding detailed debug logging to track the metadata filtering process. It also updates the similarity validation memory JSON to change the current tier from "im" to "stm". Additionally, the SimilaritySearchTestSuite is modified to include new expected memory IDs and adjust the minimum score and result limit for specific tests, enhancing the robustness of similarity search validations.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request enhances the VectorStore filtering logic by adding detailed debug logging while updating the similarity validation memory JSON and adjusting expected outcomes in the SimilaritySearchTestSuite.
- Added detailed debug logging in metadata filtering within VectorStore.
- Updated "current_tier" from "im" to "stm" in similarity validation memory JSON.
- Modified test cases in SimilaritySearchTestSuite with new expected memory IDs, adjusted min_score, and result limit.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| validation/search/similarity/similarity_test_suite.py | Updated expected memory IDs, min_score, and limit for tests |
| validation/memory_samples/similarity_validation_memory.json | Updated the value of "current_tier" to reflect the new tier |
| memory/embeddings/vector_store.py | Added debug logging to trace metadata filtering during retrieval |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…y validation
This commit improves the filtering logic in the VectorStore class by adding detailed debug logging to track the metadata filtering process. It also updates the similarity validation memory JSON to change the current tier from "im" to "stm". Additionally, the SimilaritySearchTestSuite is modified to include new expected memory IDs and adjust the minimum score and result limit for specific tests, enhancing the robustness of similarity search validations.