Conversation
This commit refines the vector storage process in the VectorStore class by consolidating the storage logic into a dedicated function for better maintainability and error handling. It also introduces a new logging utility to set up logging configurations, ensuring consistent logging practices across the application. The changes enhance the clarity and robustness of vector storage operations.
This commit refines the `store_vector` function within the VectorStore class by improving its structure and adding detailed docstrings for better clarity. It also enhances logging for vector storage operations, providing more informative debug messages for different tiers (STM, IM, LTM). Additionally, the logging utility is updated to allow for customizable log directory paths, ensuring more flexible logging configurations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces improvements to memory vector storage and logging functionality. The changes include refactoring the vector storage logic for better modularity and adding a new utility for setting up logging with enhanced configurability and filtering.
Improvements to memory vector storage:
store_memory_vectorsby introducing a helper functionstore_vectorto encapsulate the storage process, improving code readability and maintainability. This function handles storing vectors in different tiers (stm,im,ltm) and includes error handling with logging.Enhanced logging functionality:
setup_logginginmemory/utils/logging.pyto configure logging for both console and file outputs. This includes: