Skip to content

Similarity search validation#130

Merged
csmangum merged 2 commits intodevfrom
similarity-search-validation
May 17, 2025
Merged

Similarity search validation#130
csmangum merged 2 commits intodevfrom
similarity-search-validation

Conversation

@csmangum
Copy link
Copy Markdown
Contributor

This pull request introduces improvements to memory vector storage and logging functionality. The changes include refactoring the vector storage logic for better modularity and adding a new utility for setting up logging with enhanced configurability and filtering.

Improvements to memory vector storage:

  • Refactored the vector storage logic in store_memory_vectors by introducing a helper function store_vector to encapsulate the storage process, improving code readability and maintainability. This function handles storing vectors in different tiers (stm, im, ltm) and includes error handling with logging.

Enhanced logging functionality:

  • Added a new utility function setup_logging in memory/utils/logging.py to configure logging for both console and file outputs. This includes:
    • Creating a logs directory if it doesn't exist.
    • Setting up log files with a fixed naming convention.
    • Adding filters to exclude embedding-related log messages.
    • Supporting both console and file handlers with distinct formats and log levels.

csmangum added 2 commits May 16, 2025 18:08
This commit refines the vector storage process in the VectorStore class by consolidating the storage logic into a dedicated function for better maintainability and error handling. It also introduces a new logging utility to set up logging configurations, ensuring consistent logging practices across the application. The changes enhance the clarity and robustness of vector storage operations.
This commit refines the `store_vector` function within the VectorStore class by improving its structure and adding detailed docstrings for better clarity. It also enhances logging for vector storage operations, providing more informative debug messages for different tiers (STM, IM, LTM). Additionally, the logging utility is updated to allow for customizable log directory paths, ensuring more flexible logging configurations.
@csmangum csmangum merged commit 17d7b05 into dev May 17, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant