Skip to content

Super Ship Captain: Wii#1024

Merged
carda-sometimesknownas-paxilmaniac merged 4 commits into
DopplerShift13:masterfrom
She-Is-Trying-To-Form-Her-First-Thought:super-ship-captain
Apr 28, 2026
Merged

Super Ship Captain: Wii#1024
carda-sometimesknownas-paxilmaniac merged 4 commits into
DopplerShift13:masterfrom
She-Is-Trying-To-Form-Her-First-Thought:super-ship-captain

Conversation

@Paxilmaniac
Copy link
Copy Markdown

@Paxilmaniac Paxilmaniac commented Apr 25, 2026

About The Pull Request

remaps all of the large ship captain quirk shuttles to be largely smaller on average, as well as making use of the new shuttle parts afforded to us by shipbreaking
fixes a few bugs with ship captain quirk, such as the identifier key system not actually putting you on another ship captain's shuttle
ship captain quirk now has two new variables, primary and secondary ship colour, which will recolor the hull of most ships to what they are set on spawn

Here is a list of changed ships and what they look like now:

Hafila -
image

Manzil -
image

Khasun -
image

Tawsil -
image

Cigale -
image

Small DIY -
image

Medium DIY -
image

Large DIY -
image

Why It's Good For The Game

joining other people's ships being broken is bad
people being able to colour their own ships is cool
the ships being smaller so we don't have a giant terrible traffic jam everywhere is even cooler

Changelog

🆑
add: owners of the ship captain quirk can now recolour their shuttle hulls with the offered settings
fix: ship captain quirk holders can now properly join other ships with the same identifier string
map: most of the ship captain shuttles have been remapped to be even smaller to take less space in parking
/:cl:

@github-actions github-actions Bot added Map Edit Map Related UI Fix Pest removal; Bugs Feature Something new, something fresh. labels Apr 25, 2026
@SylvetteSylph
Copy link
Copy Markdown

smaller ships is quite a bit sad. kind of ganks a few gimmicks. i understand the reasoning though

@Krypandenej
Copy link
Copy Markdown

Krypandenej commented Apr 25, 2026

A few gripes here and there:
-The new ships look sick, but how feasible is it to repair them and reattach walls/parts if they get broken off?
-Will you still be able to ID lock the docking airlocks?
-I mourn for the Manzil and Khasun's bedrooms... (I am actually the least concerned about this gripe in particular)

@carda-sometimesknownas-paxilmaniac
Copy link
Copy Markdown
Collaborator

-I mourn for the Manzil and Khasun's bedrooms... (I am actually the least concerned about this gripe in particular)

they are there, just not private anymore. of course, it is your ship so whoever is let on to see is your responsibility

Copy link
Copy Markdown
Collaborator

@00-Steven 00-Steven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems fine, one not super important nitpick
no comments on the mapping

Comment on lines +82 to +86
for(var/atom/recolorable_thing as anything in new_shuttle_area.contents)
if(HAS_TRAIT(recolorable_thing, TRAIT_SHIP_PRIMARY_COLOUR))
recolorable_thing.color = ship_primary_colour
else if(HAS_TRAIT(recolorable_thing, TRAIT_SHIP_SECONDARY_COLOUR))
recolorable_thing.color = ship_secondary_colour
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

may be worth making this a separate proc taking in a shuttle area and the colours, mostly to keep the code the same between salvage shuttles and this

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Outstanding work paxilmaniac its so wonderful how all of your pull requests are amazing and powerful/

@carda-sometimesknownas-paxilmaniac carda-sometimesknownas-paxilmaniac merged commit 45637ca into DopplerShift13:master Apr 28, 2026
40 of 43 checks passed
@crossingtheline
Copy link
Copy Markdown

I'm loving this, but if I had to be asked for one gripe, it'd be the windows. Currently it's feeling a lot less like ships with two colors, and more like three with one always being blue. an option to re-color the windows or otherwise have them follow the primary or secondary colorscheme would be an absolute treat.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature Something new, something fresh. Fix Pest removal; Bugs Map Edit Map Related UI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants