Super Ship Captain: Wii#1024
Conversation
|
smaller ships is quite a bit sad. kind of ganks a few gimmicks. i understand the reasoning though |
|
A few gripes here and there: |
they are there, just not private anymore. of course, it is your ship so whoever is let on to see is your responsibility |
00-Steven
left a comment
There was a problem hiding this comment.
seems fine, one not super important nitpick
no comments on the mapping
| for(var/atom/recolorable_thing as anything in new_shuttle_area.contents) | ||
| if(HAS_TRAIT(recolorable_thing, TRAIT_SHIP_PRIMARY_COLOUR)) | ||
| recolorable_thing.color = ship_primary_colour | ||
| else if(HAS_TRAIT(recolorable_thing, TRAIT_SHIP_SECONDARY_COLOUR)) | ||
| recolorable_thing.color = ship_secondary_colour |
There was a problem hiding this comment.
may be worth making this a separate proc taking in a shuttle area and the colours, mostly to keep the code the same between salvage shuttles and this
carda-sometimesknownas-paxilmaniac
left a comment
There was a problem hiding this comment.
Outstanding work paxilmaniac its so wonderful how all of your pull requests are amazing and powerful/
45637ca
into
DopplerShift13:master
|
I'm loving this, but if I had to be asked for one gripe, it'd be the windows. Currently it's feeling a lot less like ships with two colors, and more like three with one always being blue. an option to re-color the windows or otherwise have them follow the primary or secondary colorscheme would be an absolute treat. |
About The Pull Request
remaps all of the large ship captain quirk shuttles to be largely smaller on average, as well as making use of the new shuttle parts afforded to us by shipbreaking
fixes a few bugs with ship captain quirk, such as the identifier key system not actually putting you on another ship captain's shuttle
ship captain quirk now has two new variables, primary and secondary ship colour, which will recolor the hull of most ships to what they are set on spawn
Here is a list of changed ships and what they look like now:
Hafila -

Manzil -

Khasun -

Tawsil -

Cigale -

Small DIY -

Medium DIY -

Large DIY -

Why It's Good For The Game
joining other people's ships being broken is bad
people being able to colour their own ships is cool
the ships being smaller so we don't have a giant terrible traffic jam everywhere is even cooler
Changelog
🆑
add: owners of the ship captain quirk can now recolour their shuttle hulls with the offered settings
fix: ship captain quirk holders can now properly join other ships with the same identifier string
map: most of the ship captain shuttles have been remapped to be even smaller to take less space in parking
/:cl: