Improvements during debug session at Inria testbed#216
Improvements during debug session at Inria testbed#216geonnave merged 5 commits intoDotBots:mainfrom
Conversation
d14712b to
4c1ff8a
Compare
4c1ff8a to
5f4c06d
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #216 +/- ##
==========================================
- Coverage 68.84% 68.60% -0.24%
==========================================
Files 40 40
Lines 3739 3752 +13
==========================================
Hits 2574 2574
- Misses 1165 1178 +13 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| @@ -0,0 +1,21 @@ | |||
| from dotbot.examples.charging_station.charging_station import DT as DT | |||
There was a problem hiding this comment.
How about keeping this module empty and modify the import in the corresponding test module? I would find it more convenient as it's only a one liner, even if you have to do import from dotbot.examples.charging_station.charging_station import ....
dotbot/examples/stop.py
Outdated
| @@ -0,0 +1,44 @@ | |||
| import asyncio | |||
There was a problem hiding this comment.
Can you explain the use case of this example?
There was a problem hiding this comment.
Yes: when we run any of the examples in a real robot, then when (1) when we stop the example with ctrl+c or (2) the example script crashes, the robots just keep running like crazy. This stop commands make them stop, without having to call swamit stop (and then swarmit start again). Technically we could just use swarmit stop, but right now it takes like 5 seconds or more, which is annoying from a development experience PoV.
There was a problem hiding this comment.
but could it be done in the example script directly?
in a "catch KeyboardInterrup" block, send the empty waypoint and return
There was a problem hiding this comment.
Makes sense. @WilliamTakeshi can you take a look?
0ed5d4b to
bc1f9af
Compare
No description provided.