Prebuilt table preview performance improvements#119
Merged
erdembircan merged 8 commits intomasterfrom Nov 13, 2024
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background: Loading pre-built table previews on frontend hangs editor and takes a significant time.
Solution Summary:
Known Limitations
The core of this preview system relies on WordPress's native component, which prevents ref-based approaches from functioning as intended. Specifically, the preview component loads a dummy webpage into an iframe, but without a callback for the page load completion event, the exact timing of the rendering operation cannot be pinpointed. Until WordPress provides such a callback, using a lazy loading system based on visibility remains the most accurate workaround for this issue.
Demo