Skip to content

Fix that SA1649 does not support simple names#1743

Merged
sharwell merged 1 commit intoDotNetAnalyzers:masterfrom
pdelvo:fix-1730
Nov 9, 2015
Merged

Fix that SA1649 does not support simple names#1743
sharwell merged 1 commit intoDotNetAnalyzers:masterfrom
pdelvo:fix-1730

Conversation

@pdelvo
Copy link
Copy Markdown
Member

@pdelvo pdelvo commented Nov 9, 2015

Fixes #1730.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❓ Since this is in an analyzer (as opposed to a code fix), can we implement this without the additional array and closure allocations?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed that

@sharwell sharwell added this to the 1.0.0 Beta 16 milestone Nov 9, 2015
@codecov-io
Copy link
Copy Markdown

Current coverage is 79.44%

Merging #1743 into master will decrease coverage by -0.05% as of 417eb5e

@@            master   #1743   diff @@
======================================
  Files          546     546       
  Stmts        32741   32750     +9
  Branches      9070    9074     +4
  Methods                          
======================================
- Hit          26028   26018    -10
- Partial       5269    5272     +3
- Missed        1444    1460    +16

Review entire Coverage Diff as of 417eb5e

Powered by Codecov. Updated on successful CI builds.

@vweijsters
Copy link
Copy Markdown
Contributor

👍 Looks good to me

sharwell added a commit that referenced this pull request Nov 9, 2015
Fix that SA1649 does not support simple names
@sharwell sharwell merged commit 59c1afe into DotNetAnalyzers:master Nov 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants