Update SA1519 to examine using statements#2181
Merged
sharwell merged 1 commit intoDotNetAnalyzers:masterfrom Aug 3, 2016
Merged
Update SA1519 to examine using statements#2181sharwell merged 1 commit intoDotNetAnalyzers:masterfrom
sharwell merged 1 commit intoDotNetAnalyzers:masterfrom
Conversation
| { | ||
| } | ||
| } | ||
| }"; |
Contributor
There was a problem hiding this comment.
This should be using System; (The AppVeyor build failed on this)
Contributor
|
👍 Looks good to me, except for the issue with the unit test |
Member
Author
|
@vweijsters There was also an indentation problem with the original code fix expectation. For some reason the braces for the second using statement do not get indented here. |
Current coverage is 96.77% (diff: 100%)@@ master #2181 diff @@
==========================================
Files 575 575
Lines 77703 77740 +37
Methods 3379 3388 +9
Messages 0 0
Branches 3014 3006 -8
==========================================
+ Hits 75193 75233 +40
Misses 1673 1673
+ Partials 837 834 -3
|
Contributor
|
👍 What do you want to do with the wrong indentation? Make a new issue for it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2180