Skip to content

Updates to handle included documentation#2187

Merged
sharwell merged 17 commits intoDotNetAnalyzers:masterfrom
vweijsters:fix-included-documentation
Nov 15, 2016
Merged

Updates to handle included documentation#2187
sharwell merged 17 commits intoDotNetAnalyzers:masterfrom
vweijsters:fix-included-documentation

Conversation

@vweijsters
Copy link
Copy Markdown
Contributor

@vweijsters vweijsters commented Aug 10, 2016

@vweijsters
Copy link
Copy Markdown
Contributor Author

@sharwell @pdelvo I've updated SA1605/SA1607 to support included documentation. Unfortunately this wasn't trivial due to a limitation in Roslyn. I would like some feedback on the chosen solution.

@codecov-io
Copy link
Copy Markdown

codecov-io commented Aug 10, 2016

Current coverage is 96.86% (diff: 97.00%)

Merging #2187 into master will increase coverage by 0.04%

@@             master      #2187   diff @@
==========================================
  Files           587        586      -1   
  Lines         78680      80777   +2097   
  Methods        3441       3485     +44   
  Messages          0          0           
  Branches       3027       3088     +61   
==========================================
+ Hits          76174      78242   +2068   
- Misses         1667       1696     +29   
  Partials        839        839           

Powered by Codecov. Last update 1f6c929...97f435b

@vweijsters vweijsters force-pushed the fix-included-documentation branch from 9e2256f to 45449ed Compare October 5, 2016 15:27
@vweijsters
Copy link
Copy Markdown
Contributor Author

It is (finally) ready for review

@sharwell sharwell self-assigned this Nov 15, 2016
@sharwell sharwell added this to the 1.1.0 Beta 1 milestone Nov 15, 2016
@sharwell sharwell merged commit 2a966c1 into DotNetAnalyzers:master Nov 15, 2016
@vweijsters vweijsters deleted the fix-included-documentation branch November 16, 2016 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants