Updated SA1125 to also trigger for @Nullable#2286
Merged
sharwell merged 1 commit intoDotNetAnalyzers:masterfrom Mar 13, 2017
Merged
Conversation
…nstead of Identifier.Text. The previous implementation caused false negatives when Nullable was prefixed with @.
Codecov Report@@ Coverage Diff @@
## master #2286 +/- ##
==========================================
+ Coverage 96.84% 96.84% +<.01%
==========================================
Files 598 598
Lines 84061 84078 +17
Branches 3200 3200
==========================================
+ Hits 81406 81423 +17
- Misses 1788 1790 +2
+ Partials 867 865 -2
Continue to review full report at Codecov.
|
vweijsters
approved these changes
Feb 15, 2017
bjornhellander
deleted the
Issue2284_Sa1125NotTriggeredIfNullableIsPrefixedWithAtSign
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2284