Fix SA1509 getting reported for consecutive blocks

[sharwell]

Fixes #689

[vweijsters]

What should happen with the code below? I think it will report SA1509, but I think it should not report any diagnostic.

class Foo
{
    void Bar()
    {
        /* test comment */

        {
        }

        {
        }
    }
}";

[Przemyslaw-W]

I still claim it should raise SA1509 for first nested block in both cases:

class Foo
{
    void Bar()
    {
        /* test comment */

        {
        }

        {
        }
    }
}";

and

class Foo
{
    void Bar()
    {
        // test comment

        {
        }

        {
        }
    }
}";

[Przemyslaw-W]

And also for:

class Foo
{
    void Bar()
    {
        #region Test region

        {
        }

        {
        }
        #endregion
    }
}";

[sharwell]

@vweijsters The current code reports SA1509 in that case, and this pull request does not change that. Since that line is not between blocks, it's also outside the scope of this particular issue; you can file a new issue if you'd like to see the behavior in that case changed.

@Przemyslaw-W I added unit tests to verify that the behavior of this pull request adheres to your expectations.

[codecov-io]

Current coverage is 79.50%

Merging #702 into master will not affect coverage as of bd34329

@@            master    #702   diff @@
======================================
  Files          555     556     +1
  Stmts        33508   33734   +226
  Branches      9243    9320    +77
  Methods                          
======================================
+ Hit          26640   26821   +181
- Partial       5369    5424    +55
+ Missed        1499    1489    -10

Review entire Coverage Diff as of bd34329

Powered by Codecov. Updated on successful CI builds.

[pdelvo]

The docs should reflect the behavior.

[oatkins]

👍