-
Notifications
You must be signed in to change notification settings - Fork 16
add json support for instruments and only persist user-defined instruments in playground #1076
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Caution Review failedThe pull request is closed. WalkthroughThis pull request introduces comprehensive support for JSON files across multiple components and utilities in the application. The changes span from file upload dialogs and editor configurations to type definitions and module declarations. The modifications enable JSON file handling in various parts of the system, including file type inference, editor language support, and bundler input file extensions. A new configuration file and an update to an interactive instrument's time limit configuration are also part of these changes. Changes
Sequence DiagramsequenceDiagram
participant User
participant FileUpload as File Upload Dialog
participant Editor as Monaco Editor
participant Bundler as Instrument Bundler
participant Runtime as TypeScript Runtime
User->>FileUpload: Upload JSON file
FileUpload->>Editor: Open JSON file
Editor->>Bundler: Process JSON file
Bundler->>Runtime: Type check JSON import
Runtime-->>Bundler: Validate JSON module
Bundler-->>Editor: Render JSON content
Editor-->>User: Display JSON file
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (11)
Finishing Touches
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Summary by CodeRabbit
Release Notes
New Features
Improvements
Configuration