-
Notifications
You must be signed in to change notification settings - Fork 16
feat: add addNotification function for interactive instruments #1149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add addNotification function for interactive instruments #1149
Conversation
|
Caution Review failedThe pull request is closed. WalkthroughA new runtime notification mechanism was introduced, allowing notifications to be dispatched as custom DOM events and handled by the React component. The notification type and event were defined and exported in the runtime-core package, and the React component was updated to listen for and process these events. The release workflow was also updated to change a package name. Changes
Sequence Diagram(s)sequenceDiagram
participant ExternalScript as External Script
participant RuntimeCore as runtime-core (addNotification)
participant DOM as DOM (CustomEvent)
participant InteractiveContent as React InteractiveContent
participant NotificationStore as Notification Store
ExternalScript->>RuntimeCore: call addNotification(notification)
RuntimeCore->>DOM: dispatch 'addNotification' CustomEvent with notification
DOM-->>InteractiveContent: 'addNotification' event
InteractiveContent->>NotificationStore: addNotification(notification)
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (5)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Summary by CodeRabbit