Skip to content

fix issue where retrospective session date is not recorded#1279

Merged
joshunrau merged 4 commits intoDouglasNeuroInformatics:mainfrom
joshunrau:session-date
Feb 5, 2026
Merged

fix issue where retrospective session date is not recorded#1279
joshunrau merged 4 commits intoDouglasNeuroInformatics:mainfrom
joshunrau:session-date

Conversation

@joshunrau
Copy link
Collaborator

@joshunrau joshunrau commented Feb 5, 2026

also publish new version with data table filters, fix issue where end session form doesn't close automatically, and adjust some styles

Summary by CodeRabbit

  • New Features

    • Enhanced session start modal experience with smooth animations and improved messaging to clearly guide users when an active session already exists within the system
  • Improvements

    • Improved session end dialog responsiveness, user interaction controls, and overall modal behavior for better usability
    • Refined instrument submission date handling to ensure consistency with current session values

@joshunrau joshunrau merged commit 5d1f126 into DouglasNeuroInformatics:main Feb 5, 2026
1 check passed
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 5, 2026

Caution

Review failed

The pull request is closed.

Walkthrough

This PR refines session management by converting the end-session dialog to a controlled component with local state, updating the start-session UI with improved animations and messaging, adjusting the instrument submission date source to use the current session's date, and bumping the package version to 1.13.0.

Changes

Cohort / File(s) Summary
Session Dialog Management
apps/web/src/components/Sidebar/Sidebar.tsx
Introduced local state to control end-session modal visibility. Converts dialog to a controlled component and makes the No button explicitly close the modal on click. Navigation to /session/start-session now waits for completion before closing the modal.
Session Start UI
apps/web/src/routes/_app/session/start-session.tsx
Updated modal animations (scale 0.5, 0.3s transition), restructured card layout to be centered and flex-based, and replaced conditional session status rendering with a consistent success message card shown when a session is active.
Instrument Data Recording
apps/web/src/routes/_app/instruments/render/$id.tsx
Changed date field source in instrument submission payload from new Date() to currentSession.date, making the recorded date depend on the session's date value instead of system time.
Version Bump
package.json
Updated package version from 1.12.4 to 1.13.0.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • Make session noticeable #1224: Modifies the session end and start flow with overlapping changes to the Sidebar end-session handling and start-session UI rendering.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant