minor addition to Binaural and HRTF#77
Closed
pfriedrich-hub wants to merge 210 commits intoDrMarc:masterfrom
Closed
minor addition to Binaural and HRTF#77pfriedrich-hub wants to merge 210 commits intoDrMarc:masterfrom
pfriedrich-hub wants to merge 210 commits intoDrMarc:masterfrom
Conversation
Contributor
pfriedrich-hub
commented
Oct 26, 2025
- add Binaural methods "itd_to_azimuth" and "ild_to_azimuth"
- add testing for new Binaural methods
- add docstring for HRTF method "get_sources"
- HRTF method cone_sources now has the "plane" argument, to alternatively find sources on a horizontal cone
- rework HRTF method "get_source_idx" using "cone_sources" to find sources that lie within a tolerance radius
…n if provided sofa file did not include FIR data
HRTF class is now able to read sofa files in the 'SimpleFreeFieldHRTF' convention, extract and store transfer functions as list of slab.Filter objects, which can be applied to a sound by HRTF.apply()
filter.py Filter.apply() does no longer require samplerate for fourier filters hrtf.py HRTF.apply() should now apply DTFs correctly
Filter.tf() now handles complex filter arrays
… slab Filter bank
… filters in Filter.tf()
edit sources in write_sofa
edit get datatype in init
edit get datatype in sofa_get_DTF()
…s instead of adding and subtracting
work on get_source_idx to find nearest using cone sources
remove redundant get_itd and get_ild methods
improved sofa compatibility
# Conflicts: # slab/hrtf.py
fix plotting in HRTF.plot_tf() and plot_sources()
Owner
|
Paul, could you check the failed unit tests, correct, and resend the request? |
Contributor
Author
|
Yep it’s on my todo list.
Paul
…On Fri 7. Nov 2025 at 16:54, Marc ***@***.***> wrote:
Closed #77 <#77>.
—
Reply to this email directly, view it on GitHub
<#77 (comment)>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AMTKQ2HSOA2WXVPKPXOO4K333S6DFAVCNFSM6AAAAACKH5GYRSVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMRQG44TCMZZGAYDQNI>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.