Talents reading incorrectly

[Luna2x]

Heya just wanted to report an error I seem to be having.
If you can't see the screenshot, it seems to be reading my talents incorrectly and resulting in a crazy calculation.
It has me listed as 5/2 in improved life tap talent. I'm on TBC Anniversary.
And it does calculate life tap as giving way to much mana as well

[Xerrion]

Thanks for the report! I found the root cause.

Root Cause

The TBC Anniversary client (running on the 1.15.x unified Classic client) orders talents by an internal talentID rather than the row/column grid position the old TBC Classic client used. The TalentMap_Warlock.lua keys were built using row/column sequential numbering, so 15 of 18 entries point to the wrong talent.

For example, GetTalentInfo(1, 3) returns "Improved Corruption" (5 ranks) on TBC Anniversary, but the TalentMap had index 1:3 mapped to "Improved Life Tap" (2 ranks). When you have 5/5 in Improved Corruption, the addon reads rank 5 and applies it to Improved Life Tap's per-rank modifier - producing the "5/2" display and wildly inflated calculations.

Fix

• Name-based talent matching in StateCollector - instead of relying on positional indices, I now match talents by their name returned from GetTalentInfo. This makes the addon immune to talent index reordering across client versions.
• Defensive maxRank clamping - even if something unexpected happens, talent rank is now clamped to the declared maximum.
• Corrected Warlock indices - updated to match actual TBC Anniversary in-game ordering (verified with /dump).

This likely affected all classes, not just Warlock. The name-based matching fix resolves it for everyone automatically.

[Xerrion]

Fixed in branch fix/issue-12-talent-index-mismatch. Will be included in the next release.