Add WOW_PROJECT_ID guards to version-specific Lua files (#26)#29
Merged
Add WOW_PROJECT_ID guards to version-specific Lua files (#26)#29
Conversation
* Initial plan * fix: add WOW_PROJECT_ID version guards to prevent cross-version file loading When all version-specific Lua files are loaded (e.g. from a GitHub clone or when the TOC doesn't conditionally load files), the last file's slash command handler overwrites earlier ones. Since RaidLogAuto_Classic.lua is listed last and lacks the mythic command, /rla mythic falls through to the unknown command handler on Retail. Each file now checks WOW_PROJECT_ID at the top and returns early if it doesn't match the expected game version, ensuring only the correct version-specific file initializes. Fixes #25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initial plan
fix: add WOW_PROJECT_ID version guards to prevent cross-version file loading
When all version-specific Lua files are loaded (e.g. from a GitHub clone or when the TOC doesn't conditionally load files), the last file's slash command handler overwrites earlier ones. Since RaidLogAuto_Classic.lua is listed last and lacks the mythic command, /rla mythic falls through to the unknown command handler on Retail.
Each file now checks WOW_PROJECT_ID at the top and returns early if it doesn't match the expected game version, ensuring only the correct version-specific file initializes.
Fixes #25