Compiler: use defines to make sure that .unitypackage is built correctly#21
Merged
niezbop merged 4 commits intoDragonBox:masterfrom Nov 30, 2017
Merged
Compiler: use defines to make sure that .unitypackage is built correctly#21niezbop merged 4 commits intoDragonBox:masterfrom
niezbop merged 4 commits intoDragonBox:masterfrom
Conversation
lacostej
reviewed
Nov 30, 2017
| Data.OutFile = UpliftDLL; | ||
| Data.useUnsafe = true; | ||
| Data.Defines = new string[] | ||
| { |
Member
There was a problem hiding this comment.
Data.Defines = EditorUserBuildSettings.activeScriptCompilationDefines should work!
lacostej
approved these changes
Nov 30, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This provide an actual fix for the issue #20, and revert unnecessary changes from 659c909
Fixes #20