Merged
Conversation
lacostej
reviewed
Dec 4, 2017
Member
lacostej
left a comment
lacostej
left a comment
There was a problem hiding this comment.
An alternative is to use a static or if we are concerned about multi-threading a [ThreadStatic] value or ThreadLocal instance to not have to propagate the verbose bit and change the method signatures.
Member
Author
|
This is not so much an issue with verbose. ParseIncomplete warns the user if it find identifiers (letters and such) in the version it is trying to parse. Nonetheless, sometimes, we want to be able to get rid of the warning, when parsing Unity versions for instance. Maybe I should rename the |
Member
|
"warnFormat" better than verbose. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.