Skip to content

Add upset template to export package with#33

Merged
niezbop merged 3 commits intoDragonBox:masterfrom
niezbop:feature/upset_template
Dec 7, 2017
Merged

Add upset template to export package with#33
niezbop merged 3 commits intoDragonBox:masterfrom
niezbop:feature/upset_template

Conversation

@niezbop
Copy link
Copy Markdown
Member

@niezbop niezbop commented Dec 6, 2017

No description provided.

@niezbop niezbop self-assigned this Dec 6, 2017
@niezbop niezbop requested a review from lacostej December 6, 2017 17:37
public string packageName = "";
public string packageVersion = "";
public string license = "";
public Object templateUpset = new Object();
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any reason we don't call this templateUpset I thought it was the template itself first :)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nvm, I am done reading code today...

Copy link
Copy Markdown
Member

@lacostej lacostej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks

@niezbop niezbop merged commit cdf2d7f into DragonBox:master Dec 7, 2017
@niezbop niezbop deleted the feature/upset_template branch December 7, 2017 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants