Allows to specify a proxy for GithubRepository#51
Merged
niezbop merged 4 commits intoDragonBox:masterfrom Feb 26, 2018
Merged
Conversation
Member
Author
|
NOTE: This requires #50 to be merged first |
lacostej
reviewed
Feb 26, 2018
| "The proxy URL will replace 'https://api.github.com'", | ||
| MessageType.Info | ||
| ); | ||
| githubProxyUrl = EditorGUILayout.TextField("Proxy URL", githubProxyUrl); |
Member
There was a problem hiding this comment.
we could make sure that the specified values does not end with / (or remove it if there's any).
niezbop
force-pushed
the
feature/github_proxy
branch
from
696d56c to
30e2f5d
Compare
lacostej
reviewed
Feb 26, 2018
| MessageType.Info | ||
| ); | ||
| githubProxyUrl = EditorGUILayout.TextField("Proxy URL", githubProxyUrl); | ||
| githubProxyUrl = Regex.Replace(githubProxyUrl, "/$", ""); |
niezbop
force-pushed
the
feature/github_proxy
branch
from
30e2f5d to
f111ad0
Compare
lacostej
approved these changes
Feb 26, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the recent drop of support of TLS v1.0 and v1.1 by Github, we need to go through a proxy to use the GithubRepository. This implements what is needed to do so.