Merged
Conversation
- Extract .unitypackage extraction from FileRepository to a new class UnityPackageOpener. - Various cleaning of calls inside FileRepositor# Please enter the commit message for your changes. Lines starting
lacostej
reviewed
Nov 8, 2017
| { | ||
| public class UnityPackageOpener | ||
| { | ||
| public void OpenUnityPackage(string archivePath, bool deleteAfterOpening = false) |
Member
There was a problem hiding this comment.
Would ExtractUnityPackage be a better name?
| deleteAfterOpening | ||
| ); | ||
| } | ||
| public void OpenUnityPackage(string archivePath, string destinationPath, bool deleteAfterOpening = false) |
Member
There was a problem hiding this comment.
We should say what happens when destinationPath doesn't exist.
| deleteAfterOpening | ||
| ); | ||
| } | ||
| public void OpenUnityPackage(string archivePath, string destinationPath, bool deleteAfterOpening = false) |
Member
There was a problem hiding this comment.
Is deleteAfterOpening needed? What's the use case?
Member
Author
There was a problem hiding this comment.
None actually. Removing it
niezbop
force-pushed
the
refactor/extract_unitypackage_decompression
branch
from
1659fce to
4fc3123
Compare
lacostej
reviewed
Nov 8, 2017
|
|
||
| namespace Uplift.Common | ||
| { | ||
| public class UnityPackageOpener |
Member
There was a problem hiding this comment.
Maybe the API should be
new UnityPackage(filePath).Extract(destination)
lacostej
approved these changes
Nov 8, 2017
Member
lacostej
left a comment
lacostej
left a comment
There was a problem hiding this comment.
Great. Thanks for the cleanups!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extract .unitypackage extraction from FileRepository to a new class UnityPackageOpener.
Various cleaning of calls inside FileRepository