feat(sysfs): implement group_remove_files to complete attribute group removal#1873
Merged
oeasy1412 merged 3 commits intoDragonOS-Community:masterfrom Apr 24, 2026
Merged
Conversation
github-actions
Bot
added
enhancement
Signed-off-by: vio-vv <haoweihuang@dragonos.org>
oeasy1412
approved these changes
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed #1835
This PR implement the group_remove_files function, complete sysfs attribute group removal, and fix attribute group lifecycle management issues.
Main Changes
Implemented the removal logic for each attribute file in the attribute group
Fix the removal logic in
remove_dir(&self, kobj: &Arc<dyn KObject>)andkernel/src/filesystem/sysfs/group.rsto avoid accidental removal and directory leakAbout dunitest: due to unimpletement of init_module syscall, user-space test is not added in this PR