Xcode 10 / Mojave / Swift 4.2 issue?

[fblecha]

I'm getting a black rendering for my view on something that was previously working after upgrading to:

• Xcode 10 (app store version)
• Mojave
• Swift 4.2

I'm downloading Xcode 9.4.1 to see if that's the issue and am going to step through it.

Anyone else seeing this?

[MaddTheSane]

IIRC, anything that calls lockFocus to a view don't work on Mojave. I had something similar happen on my NetHack3D branch, and I think DrawKit uses lockFocus.

[fblecha]

any work around you'd suggest @MaddTheSane ? I'm used to looking at DrawKit internals, but I haven't tried modifying it at all. Is that the route that's going to have to happen for mojave support?

[fblecha]

Ok, the following works:

• swift 4.1.2
• xcode 9.4.1
• Mojave

any thoughts on what Xcode or swift 4.2 are doing to jack it up?

[MaddTheSane]

My guess is the targeting of the Mojave SDK. 9.4.1 targets the High Sierra SDKs, and Mac OS X does some trickery to make sure apps built against older SDKs still work somewhat.

[MaddTheSane]

Looking through the code, I found one method that calls -[NSView lockFocus] is in DKLayerGuide… if DK_DRAW_GUIDES_IN_CLIP_VIEW is set. Other than that, DKDrawingView does override -lockFocusIfCanDraw, and the comment suggests that the code could go into -viewWillDraw. In fact, it wouldn't surprise me if apps/frameworks linking against Mojave aren't calling -lockFocusIfCanDraw and thus the needed functions aren't getting called.

[fblecha]

@MaddTheSane if you haven't had the chance to test it on xcode10 / mojave / swift 4.2 yet, I'll get to it this evening.

[fblecha]

@MaddTheSane been a while since I worked on the project that used this -- did the change you implemented with ff220d6 means it should work with Xcode 10 now?

[MaddTheSane]

It should.

[fblecha]

confirm it works - we should tag a new release @MaddTheSane @grahammiln - 1.0.4?