Fix CheckboxFilter #207, Table mobile headers #210, release workflow#232
Merged
Fix CheckboxFilter #207, Table mobile headers #210, release workflow#232
Conversation
…tions When values contained entries not present in options (e.g. values=[0,1,3] with options [0,1,2]), the component displayed "3 selected" while only 2 checkboxes were checked. Now filters values against options before counting. Also adds a dev-mode warning when unmatched values are detected. Fixes #207 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…ments When headers contained complex children (sortable arrows, divisor divs), _addAttributesToCells extracted the full children tree and set it as data-th. The CSS ::before pseudo-element then rendered the stringified array with comma separators (e.g. "PROJECT,,"). Now extracts only the text content from header cells for the data-th attribute. Fixes #210 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
softprops/action-gh-release requires GITHUB_REF to contain a tag ref. The create event doesn't reliably set this, causing "GitHub Releases requires a tag" errors. Using on:push:tags is the standard pattern. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…ase workflow actions/checkout configures a GITHUB_TOKEN credential helper that overrides the remote URL token. Tags pushed with GITHUB_TOKEN don't trigger downstream workflows (GitHub's loop prevention). Passing the PAT via checkout's token param ensures tags trigger release.yml. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
data-thattribute instead of full React element treeon: create: tags→on: push: tagssosoftprops/action-gh-releasecan find the tagGH_TOKENPAT in checkout so tag pushes trigger the Release workflow (GitHub blocksGITHUB_TOKEN-created events from triggering downstream workflows)Test plan
testjob passes🤖 Generated with Claude Code