Decoder sdcard decoding fix and speed improvement#383
Merged
DreamSourceLab merged 2 commits intoDreamSourceLab:masterfrom Oct 27, 2021
lambdaconcept:master
Merged
Decoder sdcard decoding fix and speed improvement#383DreamSourceLab merged 2 commits intoDreamSourceLab:masterfrom lambdaconcept:master
DreamSourceLab merged 2 commits intoDreamSourceLab:masterfrom
lambdaconcept:master
Conversation
This improves the decoding speed a lot (~8x faster), especially when using a high sampling rate.
…decoding Description of the bug fix: When a command is not supported by the sdcard, the command is silently dropped with no response. The host will then either reemit the same command or give up. This causes the previous decoder implementation to go out of sync and wrongly decode the next message as a response even though it's not. This patch looks at the transmission bit instead to make sure the decoding is correct.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
2 patches:
Decoder sdcard: trigger the decoding on clock raising edge
This improves the decoding speed a lot (~8x faster), especially
when using a high sampling rate.
Decoder sdcard: look at the transmission bit for command or response decoding
Description of the bug fix:
When a command is not supported by the sdcard, the command is silently
dropped with no response. The host will then either reemit the same command
or give up. This causes the previous decoder implementation to go out of
sync and wrongly decode the next message as a response even though it's not.
This patch looks at the transmission bit instead to make sure the
decoding is correct.