Added disable anonymous bulk download#102
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a client-side disableAnonymousBulkDownloads feature flag that prevents non-logged-in users from triggering bulk downloads (multi-file selections or directory/whole-dataset downloads) from both the dataset header and the shared context menu.
Changes:
- Adds new
DISABLE_ANONYMOUS_BULK_DOWNLOADSfeature flag constant. - Adds bulk-selection detection and an
isEnabledgate to the shared Download context menu item. - Adds
downloadIsBulk/downloadBlocked/downloadTitlecomputeds inHeader.vueand disables the header download button accordingly.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| webapp/js/libs/features.js | Declares the new feature flag constant. |
| webapp/js/libs/contextMenuItems.js | Disables the Download menu item for anonymous bulk selections. |
| webapp/js/layout/Header.vue | Disables the header download button and updates its tooltip when bulk downloads are blocked. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As title says