deps(deps): bump actions/download-artifact from 4 to 8#2
Open
dependabot[bot] wants to merge 1 commit intomainfrom
Open
deps(deps): bump actions/download-artifact from 4 to 8#2dependabot[bot] wants to merge 1 commit intomainfrom
dependabot[bot] wants to merge 1 commit intomainfrom
Conversation
Author
LabelsThe following labels could not be found: Please fix the above issues or remove invalid values from |
33600d0 to
01f7bba
Compare
7a0b1fd to
de6c945
Compare
DrunkOnJava
added a commit
that referenced
this pull request
Apr 21, 2026
…id targets input Two failures observed on runs #1 and #2: 1. `setup-rust-toolchain@v1.9.0` rejected the `targets:` key (singular `target` is the correct input). Non-fatal warning, but meant wasm32-unknown-unknown wasn't pre-installed and wasm-pack had to rustup-add it at build time. 2. `wasm-pack build --target web --features wasm --no-default-features --out-dir viewer/pkg` failed with "error: unexpected argument '--out-dir' found". Root cause: wasm-pack forwards every arg after the first one it doesn't recognise to `cargo build`. Because `--features` came before `--out-dir`, the latter was sent to cargo — which doesn't support it. Fix: wasm-pack build --target web -- --features wasm --no-default-features rm -rf viewer/pkg mv pkg viewer/pkg The `--` separator is the canonical way to split wasm-pack args from cargo pass-through args. Building into the default `pkg/` then moving it sidesteps `--out-dir` entirely. Also: hoisted the `apt-get install wabt` install ahead of the import-table audit (was running lazily inside the verify step) and dropped the lockfile-based npm cache that the action warned about since `viewer/package-lock.json` isn't committed yet.
e2784af to
7624f0a
Compare
DrunkOnJava
added a commit
that referenced
this pull request
Apr 21, 2026
…100% clean on Einhoven Partitions/5
Applied the D13 filter (buf[pos+2..pos+4] == 0x0000) across all 80
tagged classes on three partition streams. Results split cleanly:
Real records (>50% kept):
- AnalyticalLevelAssociationCell: 60-91% kept, up to 797K records on 2024
- A3PartyAImage: 77-97% kept
- ADTGridImportVocabulary: 24-95% kept
- APIVSTAMacroElem*: 80-99% kept
- ArcWall (0x0191): **32/32 kept on Einhoven Partitions/5 = 100%**
Bimodal (10-40% kept, partly text artifact):
- HostObjAttr: 11-34% kept across streams (as RE-14.1 found)
- AbsDbViewPressureLossReport: 11-28%
- AppearanceAsset: 23%
Pure text artifact (<5% kept):
- AbsCurveGStep (0x0061): 0.9% kept — letter 'a' in UTF-16 strings.
This was RE-11's #2 signal but is effectively all noise.
Coherence check: Einhoven Partitions/0 filtered=20548 records / 30
classes = ~15 subrecords/element against the ~1411 ElemTable count.
Reasonable composition ratio for "Wall = HostObjAttr + Cells + GeomStep".
Critical: ArcWall (0x0191) shows only on Partitions/5, zero on
Partitions/0 — evidence that partition stream numbers correlate with
element categories (H12 new, conf 0.6).
ArcWall is the cleanest unblocking target for the whole element-decode
pipeline:
- 32 records, 100% real
- Direct Wall subtype (no ancestor walk needed)
- Small enough to inspect each manually
- Unblocks RE-15, DEC-01..05, and finishes DEC-05 (IfcWall count > 0)
New hypotheses: H10 raised 0.9->0.95 (filter methodology validated
across 3 streams), H11 raised 0.5->0.8 (all top-signal tags bimodal),
H12 new (partition number correlates with element category), H13 new
(variable-length record bodies — ~18 KB average per ArcWall).
Decisions: D16 (filter becomes default for tag-signal scans), D17
(ArcWall Partitions/5 is next target), D18 (tasks RE-15, DEC-01..05
unblocked pending RE-14.3).
Next step: probe_arcwall_records.rs hex-dumps 32 records to extract
envelope + body layout.
a28ff98 to
22ed82c
Compare
Bumps [actions/download-artifact](https://github.com/actions/download-artifact) from 4 to 8. - [Release notes](https://github.com/actions/download-artifact/releases) - [Commits](actions/download-artifact@v4...v8) --- updated-dependencies: - dependency-name: actions/download-artifact dependency-version: '8' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
22ed82c to
01820c8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps actions/download-artifact from 4 to 8.
Release notes
Sourced from actions/download-artifact's releases.
... (truncated)
Commits
3e5f45bAdd regression tests for CJK characters (#471)e6d03f6Add a regression test for artifact name + content-type mismatches (#472)70fc10cMerge pull request #461 from actions/danwkennedy/digest-mismatch-behaviorf258da9Add change docsccc058eFix linting issuesbd7976bAdd a setting to specify what to do on hash mismatch and default it toerrorac21fcfMerge pull request #460 from actions/danwkennedy/download-no-unzip15999bfAdd note about package bumps974686eBump the version tov8and add release notesfbe48b1Update test names to make it clearer what they do