Conversation
6 tasks
Passt was an alternative networking backend that caused supervisor process leaks — passt processes were not cleaned up on VM stop/remove, accumulating zombie entries in the supervisor. Remove all passt support in favor of bridge and user networking modes.
kvinwang
force-pushed
the
remove-passt
branch
from
75b1f14 to
8159538
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
stop_vmandremove_vmdidn't clean them up; removing the mode entirely eliminates this class of bugsChanged files
vmm/src/config.rs— RemoveNetworkingMode::Passt, passt struct fields,is_passt()vmm/src/app.rs— Remove passt stop/remove logic fromstart_vmandremove_vmvmm/src/app/qemu.rs— Removeconfig_passt(),Passtmatch arm, passt workdir methodsvmm/src/main_service.rs— Remove passt from proto conversionvmm/src/vmm-cli.py— Remove 'passt' from--netchoicesvmm/src/console_v1.html— Remove Passt option from UI dropdownvmm/vmm.toml— Remove passt config sectionvmm/rpc/proto/vmm_rpc.proto— Update commentTest plan
cargo fmtandcargo clippypassuserandbridgenetworking modes still work