Skip to content

ci: fix docker-build-check for PRs from forks #654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kvinwang merged 1 commit into from
Apr 22, 2026
+18 −14
Merged

ci: fix docker-build-check for PRs from forks #654

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 18 additions & 14 deletions .github/workflows/docker-build-check.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,10 @@ on:
pull_request:
branches: [ master, next, dev-* ]

env:
DSTACK_REV: ${{ github.event.pull_request.head.sha || github.sha }}
DSTACK_SRC_URL: ${{ github.event.pull_request.head.repo.clone_url || format('{0}/{1}', github.server_url, github.repository) }}

jobs:
gateway:
runs-on: ubuntu-latest
Expand All @@ -30,8 +34,8 @@ jobs:
build-contexts: |
build-shared=build/shared
build-args: |
DSTACK_REV=${{ github.event.pull_request.head.sha || github.sha }}
DSTACK_SRC_URL=${{ github.server_url }}/${{ github.repository }}
DSTACK_REV=${{ env.DSTACK_REV }}
DSTACK_SRC_URL=${{ env.DSTACK_SRC_URL }}

- name: Verify pinned packages
run: |
Expand All @@ -46,8 +50,8 @@ jobs:
--tag gateway-builder-check:latest \
--provenance=false \
--build-context build-shared=build/shared \
--build-arg "DSTACK_REV=${{ github.event.pull_request.head.sha || github.sha }}" \
--build-arg "DSTACK_SRC_URL=${{ github.server_url }}/${{ github.repository }}" \
--build-arg "DSTACK_REV=${DSTACK_REV}" \
--build-arg "DSTACK_SRC_URL=${DSTACK_SRC_URL}" \
gateway/dstack-app/builder

- name: Verify builder pinned packages
Expand All @@ -74,8 +78,8 @@ jobs:
build-contexts: |
build-shared=build/shared
build-args: |
DSTACK_REV=${{ github.event.pull_request.head.sha || github.sha }}
DSTACK_SRC_URL=${{ github.server_url }}/${{ github.repository }}
DSTACK_REV=${{ env.DSTACK_REV }}
DSTACK_SRC_URL=${{ env.DSTACK_SRC_URL }}

- name: Verify pinned packages (qemu stage)
run: |
Expand All @@ -90,8 +94,8 @@ jobs:
--tag kms-builder-check:latest \
--provenance=false \
--build-context build-shared=build/shared \
--build-arg "DSTACK_REV=${{ github.event.pull_request.head.sha || github.sha }}" \
--build-arg "DSTACK_SRC_URL=${{ github.server_url }}/${{ github.repository }}" \
--build-arg "DSTACK_REV=${DSTACK_REV}" \
--build-arg "DSTACK_SRC_URL=${DSTACK_SRC_URL}" \
kms/dstack-app/builder

- name: Verify builder pinned packages
Expand Down Expand Up @@ -125,8 +129,8 @@ jobs:
build-contexts: |
build-shared=build/shared
build-args: |
DSTACK_REV=${{ github.event.pull_request.head.sha || github.sha }}
DSTACK_SRC_URL=${{ github.server_url }}/${{ github.repository }}
DSTACK_REV=${{ env.DSTACK_REV }}
DSTACK_SRC_URL=${{ env.DSTACK_SRC_URL }}

- name: Verify pinned packages (runtime)
run: |
Expand All @@ -142,8 +146,8 @@ jobs:
--provenance=false \
--file verifier/builder/Dockerfile \
--build-context build-shared=build/shared \
--build-arg "DSTACK_REV=${{ github.event.pull_request.head.sha || github.sha }}" \
--build-arg "DSTACK_SRC_URL=${{ github.server_url }}/${{ github.repository }}" \
--build-arg "DSTACK_REV=${DSTACK_REV}" \
--build-arg "DSTACK_SRC_URL=${DSTACK_SRC_URL}" \
verifier

- name: Verify builder pinned packages
Expand All @@ -160,8 +164,8 @@ jobs:
--provenance=false \
--file verifier/builder/Dockerfile \
--build-context build-shared=build/shared \
--build-arg "DSTACK_REV=${{ github.event.pull_request.head.sha || github.sha }}" \
--build-arg "DSTACK_SRC_URL=${{ github.server_url }}/${{ github.repository }}" \
--build-arg "DSTACK_REV=${DSTACK_REV}" \
--build-arg "DSTACK_SRC_URL=${DSTACK_SRC_URL}" \
verifier

- name: Verify qemu pinned packages
Expand Down
Loading