Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a Prometheus-compatible metrics endpoint to the dstack-kms Rocket service and instruments attestation-related pRPC calls with in-process counters.
Changes:
- Add
KmsMetricscounters toKmsStateand a Prometheus text renderer. - Expose
GET /metricsreturning Prometheus text format. - Record attestation request/failure counts via a Rocket
on_responsefairing to include pre-handler failures.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| kms/src/main_service.rs | Introduces KmsMetrics in shared state and renders Prometheus exposition text. |
| kms/src/main.rs | Adds /metrics route and a response fairing to record attestation metrics for selected pRPC methods. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GET /metricsto dstack-kms in Prometheus text formatdstack_kms_attestation_requests_totalanddstack_kms_attestation_failures_totalcountersTest
rustfmt --edition 2021 --check kms/src/main.rs kms/src/main_service.rscargo check -p dstack-kms