Fix ra-tls certificate SAN generation for IP-only endpoints#673
Merged
Conversation
kvinwang
approved these changes
May 11, 2026
Collaborator
kvinwang
left a comment
There was a problem hiding this comment.
LGTM, thanks for the fix!
This was referenced May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ra_tls::cert::CertRequest::into_cert_paramsconverts every configured subject alternative name intoSanType::DnsName, so an IP literal like203.0.113.10is encoded as a DNS SAN.dstack/ra-tls/src/cert.rs
Lines 372 to 378 in 4b7372d
rustls/webpki requires IP endpoints to be represented as actual IP SANs, so name verification fails when clients connect by IP address. This makes it difficult to use
ra_tlsfor IP-only hosts. See related issue in our attested-tls implementation which depends onra-tls: flashbots/attested-tls#30This PR delegates SAN parsing to
rcgen::CertificateParams::new(...), which internally converts IP literals intoSanType::IpAddressand leaves hostnames as DNS SANs.So this is a behavioral change, but it only effects names which successfully parse as IP addresses.
A test covering mixed SANs is included which checks that:
203.0.113.10is encoded asSanType::IpAddresstest.example.comremainsSanType::DnsName