fix: upgrade OVMF to edk2-stable202505 tagged release#50
Conversation
Switch from an untagged master branch commit (3a3b12cb, 2024-09-20) to the edk2-stable202505 tagged release. This ensures the UEFI firmware has undergone release-level QA and is tracked by edk2 security advisories. Refresh patches 0003-0005 to apply cleanly against the new base. Partially addresses: #47
kvinwang
force-pushed
the
fix/ovmf-use-stable-release
branch
from
35bfbb7 to
f9f11f3
Compare
There was a problem hiding this comment.
Pull request overview
Upgrades the pinned edk2/OVMF source revision used by the Yocto dstack-ovmf recipe from an untagged master commit to the edk2-stable202505 release commit, and refreshes local patches to apply against the new base.
Changes:
- Bump
PV/SRCREVtoedk2-stable202505(6951dfe7…). - Refresh patch headers/context for patches 0003–0005 to apply cleanly on the new edk2 base.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| meta-dstack/recipes-core/dstack-ovmf/dstack-ovmf_git.bb | Updates the edk2 version/revision pinned by the OVMF recipe. |
| meta-dstack/recipes-core/dstack-ovmf/dstack-ovmf/0003-Debug-prefix-map.patch | Refreshed patch metadata/context for new upstream base. |
| meta-dstack/recipes-core/dstack-ovmf/dstack-ovmf/0004-Reproduciable.patch | Refreshed patch metadata/context for new upstream base. |
| meta-dstack/recipes-core/dstack-ovmf/dstack-ovmf/0005-Declare-ProcessLibraryConstructorList.patch | Refreshed patch metadata/context for new upstream base. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| SRC_URI = "gitsm://github.com/tianocore/edk2.git;branch=master;protocol=https \ | ||
| file://0001-Update-path-to-native-BaseTools.patch \ | ||
| file://0002-BaseTools-makefile-adjust-to-build-in-under-bitbake.patch \ | ||
| file://0003-Debug-prefix-map.patch \ | ||
| file://0004-Reproduciable.patch \ | ||
| file://0005-Declare-ProcessLibraryConstructorList.patch \ | ||
| " | ||
|
|
||
| PV = "edk2-3a3b12cb" | ||
| SRCREV = "3a3b12cbdae2e89b0e365eb01c378891d0d9037c" | ||
| PV = "edk2-stable202505" | ||
| SRCREV = "6951dfe7d59d144a3a980bd7eda699db2d8554ac" |
There was a problem hiding this comment.
SRC_URI still fetches edk2 from branch=master even though PV/SRCREV now point at the edk2-stable202505 release. To ensure the fetch is tied to the stable release line (and avoid failures if the release commit isn’t reachable from master), update SRC_URI to use the edk2-stable202505 branch (or alternatively drop branch= and use the appropriate fetcher options for a tag-based pin).
| Date: Mon, 4 Nov 2024 04:29:41 +0000 | ||
| Subject: [PATCH 4/5] Reproduciable | ||
| Date: Wed, 18 Mar 2026 08:44:21 +0000 | ||
| Subject: [PATCH] Reproduciable |
There was a problem hiding this comment.
Patch subject has a spelling error: “Reproduciable” should be “Reproducible”. Keeping this consistent helps with patch readability and future maintenance (and matches the intent of the patch).
| Subject: [PATCH] Reproduciable | |
| Subject: [PATCH] Reproducible |
Summary
3a3b12cb, 2024-09-20) toedk2-stable202505tagged release (6951dfe7)Test plan
bitbake dstack-ovmfbuilds successfully with no patch-fuzz warningsbuild.sh guestimage build passesPartially addresses #47