base.t, file.t: unlink temporary files created during testing#7
Merged
Merged
Conversation
Collaborator
|
looks great. thanks Jim! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I run the Perl 5 core distribution's test suite dozens of times each week. If a test file within the core distribution's test suite creates a temporary file but fails to remove it before the test program completes, then I accumulate a large number of such tempfiles on my machine's
/tmp.The Digest distribution on CPAN ships with the core. Two of its test files create tempfiles but fail to remove them. Consequently, I accumulate a large number of files with identical content. Examples:
This pull request unlinks the temporary files once they're no longer needed. Please review and issue a new CPAN release so that we can synch this into core.
Thank you very much.
Jim Keenan