Skip to content

Update .editorconfig#202

Merged
adamralph merged 1 commit intomainfrom
dgb/update-editorconfig-20250513211008
Aug 5, 2025
Merged

Update .editorconfig#202
adamralph merged 1 commit intomainfrom
dgb/update-editorconfig-20250513211008

Conversation

@duende-github-bot
Copy link
Copy Markdown

Synchronizing .editorconfig.

@adamralph adamralph marked this pull request as draft May 14, 2025 09:50
@adamralph
Copy link
Copy Markdown
Member

adamralph commented May 14, 2025

I think part of this PR should be ensuring that <TreatWarningsAsErrors>true</TreatWarningsAsErrors> is present in every project for release builds, whether by Directory.Build.props or otherwise. It currently is for some, but not for all. Marking as a draft until that's done.

@bhazen bhazen force-pushed the dgb/update-editorconfig-20250513211008 branch from 84e51db to edaab9b Compare July 14, 2025 19:40
@bhazen
Copy link
Copy Markdown
Contributor

bhazen commented Jul 14, 2025

I think part of this PR should be ensuring that <TreatWarningsAsErrors>true</TreatWarningsAsErrors> is present in every project for release builds, whether by Directory.Build.props or otherwise. It currently is for some, but not for all. Marking as a draft until that's done.

@adamralph every Directory.Build.props currently references the top-level src.props which conditionally has <TreatWarningsAsErrors>true</TreatWarningsAsErrors> for release builds. Is that sufficient for addressing your comment and moving this from a draft to ready for review?

@adamralph
Copy link
Copy Markdown
Member

adamralph commented Aug 5, 2025

I think part of this PR should be ensuring that <TreatWarningsAsErrors>true</TreatWarningsAsErrors> is present in every project for release builds, whether by Directory.Build.props or otherwise. It currently is for some, but not for all. Marking as a draft until that's done.

@adamralph every Directory.Build.props currently references the top-level src.props which conditionally has <TreatWarningsAsErrors>true</TreatWarningsAsErrors> for release builds. Is that sufficient for addressing your comment and moving this from a draft to ready for review?

@bhazen sorry, this one slipped through the cracks.

Yes, I see that they do all indeed reference the top-level src.props now. I think, at the time I wrote that comment, there was something that didn't reference it, but I may have imagined it. This looks good to go now.

@adamralph adamralph marked this pull request as ready for review August 5, 2025 05:02
Copilot AI review requested due to automatic review settings August 5, 2025 05:02
@adamralph adamralph force-pushed the dgb/update-editorconfig-20250513211008 branch from edaab9b to e9aff04 Compare August 5, 2025 05:02
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR synchronizes the .editorconfig file by reducing the severity of C# code analysis rules from "error" to "warning". This change makes the code analysis rules less strict, allowing builds to succeed even when these style and formatting rules are violated.

  • Changes diagnostic rule severities from error to warning for various IDE rules
  • Updates qualification style rules from error to warning severity

@adamralph adamralph merged commit 91da90e into main Aug 5, 2025
15 checks passed
@adamralph adamralph deleted the dgb/update-editorconfig-20250513211008 branch August 5, 2025 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants