Skip to content

simplify private asset package references#271

Merged
adamralph merged 1 commit intomainfrom
private-assets
Oct 3, 2025
Merged

simplify private asset package references#271
adamralph merged 1 commit intomainfrom
private-assets

Conversation

@adamralph
Copy link
Copy Markdown
Member

What issue does this PR address?

Redundant private asset package reference complexity.

@adamralph adamralph self-assigned this Oct 2, 2025
@adamralph adamralph requested review from a team and Copilot October 2, 2025 14:47
@adamralph adamralph added the area/foss Across all components. label Oct 2, 2025
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR simplifies MSBuild package references by reducing verbose XML configurations for private asset packages. The changes streamline package reference declarations while maintaining the same functionality.

  • Removed verbose multi-line PrivateAssets and IncludeAssets XML elements
  • Converted to inline attribute syntax where PrivateAssets="all" is needed
  • Simplified test-only package references to basic self-closing tags

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
test.props Simplified coverlet.collector and xunit.runner.visualstudio package references to basic declarations
src.props Converted MinVer package reference from verbose XML to inline PrivateAssets attribute

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread test.props
Comment thread test.props
@adamralph adamralph merged commit 1144ce2 into main Oct 3, 2025
15 checks passed
@adamralph adamralph deleted the private-assets branch October 3, 2025 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/foss Across all components.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants