Skip to content

Conversation

@saakshiraut28
Copy link
Contributor

Fixes Issue

My PR closes #430

πŸ‘¨β€πŸ’» Changes proposed(What did you do ?)

  • Do not show the result screen if the inputs are not entered.
  • Change the Get Result button to grey color if the inputs are not entered.
  • Add an error indicator if the Get Result button is clicked and the input is not provided.

βœ”οΈ Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • This PR does not contain plagiarized content.
  • The title and description of the PR is clear and explains the approach.

Note to reviewers

πŸ“· Screenshots

The button color is turned to grey when the input is not entered:
codemagic1

When the user tries to click on Get Result button without entering the input:

codemagic2.mp4

@vercel
Copy link

vercel bot commented Aug 18, 2023

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
code-magic βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Aug 22, 2023 1:42pm

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks Passed!

@Dun-sin
Copy link
Owner

Dun-sin commented Aug 18, 2023

PR Compliance Checks

Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.

Conventional Commit PR Title

In order to be considered for merging, the pull request title must match the specification in conventional commits. You can edit the title in order for this check to pass.
Most often, our PR titles are something like one of these:

  • docs: correct typo in README
  • feat: implement dark mode"
  • fix: correct remove button behavior

Linting Errors

  • Found type "null", must be one of "feat","fix","docs","style","refactor","perf","test","build","ci","chore","revert"
  • No subject found

@saakshiraut28

@Dun-sin
Copy link
Owner

Dun-sin commented Aug 18, 2023

You also have some build errors please fix that, you can see what it says by running "npm run build"

@Dun-sin
Copy link
Owner

Dun-sin commented Aug 22, 2023

You also have some build errors please fix that, you can see what it says by running "npm run build"

@saakshiraut28 are you going to make the correction or I can close the PR?

@saakshiraut28
Copy link
Contributor Author

I'll fix the errors.

@saakshiraut28 saakshiraut28 changed the title [FEATURE] Prevent getting results for gradient background if there is no input feat: Avoid gradient background results without input. Aug 22, 2023
@saakshiraut28
Copy link
Contributor Author

Hi @Dun-sin, the changes have been made. Please review and let me know if there's anything else you'd like me to add.

Copy link
Owner

@Dun-sin Dun-sin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except the Change in index.html everything else is good

@Dun-sin Dun-sin merged commit 506f88d into Dun-sin:main Aug 23, 2023
@Dun-sin
Copy link
Owner

Dun-sin commented Aug 23, 2023

πŸŽ‰ This PR is included in version 2.64.0 πŸŽ‰

The release is available on GitHub release

Your semantic-release bot πŸ“¦πŸš€

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE] prevent getting results for gradient background if there is no input

2 participants