fix: Null properties removed from generated css code #497
Conversation
…values before genearting css
…alue before generating css code
…efore generating the result
…values b4 generating the result
…ues of gradient-border
…efore box shadow generation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
… input value before generating css code" This reverts commit ff9a0c9.
…changed to enhance readability
…e input values b4 generating the result" This reverts commit 73929aa.
…e input values before genearting css" This reverts commit e10ccab.
… before generating css code
…nput values of gradient-border" This reverts commit 65f328b.
|
@Dun-sin I have reverted back the changes you had asked for. I have resolved the review conversation as scrolling through so many reviews was causing a lot of confusion. Can you check once and let me know if any other part of the code need to be reverted back? I will commit new changes related to this issue once all the reviews are resolved to avoid confusion. |
Dun-sin
left a comment
Dun-sin
left a comment
There was a problem hiding this comment.
your Pr should only contain generators that don't have the get results button
|
@Bismay5467 You missed a few things, doesn't work for tailwind code that still copies |
Yeah, I know. I am trying to fix it for css first. Once this works while generating css code, doing the same for generating tailwind css would be a cakewalk. |
@Dun-sin In generators like gradient background suppose the user add a third color input box but fill only the first two color input boxes, then the background field in the css code remains null. Do i need to check for null value display a notification for that ? |
Dun-sin
left a comment
Dun-sin
left a comment
There was a problem hiding this comment.
You did great, thanks for contributing, I hope you will stick around and continue to contribute to this project.
Consider giving this project a star and joining the community discord server if you haven't for more resources and opportunities to connect with others. 👉🏽here👈🏽
|
🎉 This PR is included in version 2.70.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
2 participants
Fixes #486
✔️ Check List (Check all the applicable boxes)
📷 Screenshots
@Dun-sin I am still working on this issue, but I would like to have a initial review from your side. Any feedback or suggestion would be highly appreciated!