Skip to content

Conversation

@kantakshay
Copy link
Contributor

Fixes Issue

**My PR closes #467

πŸ‘¨β€πŸ’» Changes proposed(What did you do ?)

  • first of all, I changed the styles of the checkbox as per the new design.
  • Added + and - buttons beside the input element
  • styled them so they look good.
  • Implemented function to the + and - buttons so they can add or subtract the values of input elements.
  • for the function implementation I made changes in the input-range.ts and getElement.ts files

βœ”οΈ Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • This PR does not contain plagiarized content.
  • The title and description of the PR is clear and explains the approach.

Note to reviewers

πŸ“· Screenshots

Screenshot (183)

Copy link
Owner

@Dun-sin Dun-sin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you don't need to create a new PR, those changes can be added by amending the existing one

@vercel
Copy link

vercel bot commented Oct 17, 2023

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
code-magic βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Oct 18, 2023 6:54am

@Dun-sin
Copy link
Owner

Dun-sin commented Oct 17, 2023

you forgot the space between i talked about
image

@Dun-sin
Copy link
Owner

Dun-sin commented Oct 17, 2023

Doesn't look good on mobile
Screenshot_2023-10-17-11-15-15-299_com.brave.browser-edit.jpg

@Dun-sin
Copy link
Owner

Dun-sin commented Oct 18, 2023

still the same, use flex to properly style -> in case you don't know how to use it https://css-tricks.com/snippets/css/a-guide-to-flexbox/
use the space between to give a space between them, don't gap for situations like this
image

it should look like this:
image

Copy link
Owner

@Dun-sin Dun-sin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You did great, thanks for contributing, I hope you will stick around and continue to contribute to this project.

Consider giving this project a star and joining the community discord server if you haven't for more resources and opportunities to connect with others. πŸ‘‰πŸ½hereπŸ‘ˆπŸ½

@Dun-sin
Copy link
Owner

Dun-sin commented Oct 18, 2023

πŸŽ‰ This PR is included in version 2.71.0 πŸŽ‰

The release is available on GitHub release

Your semantic-release bot πŸ“¦πŸš€

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE] better styling for thumb/track radius

2 participants