Skip to content

Conversation

@viditagrawal56
Copy link
Contributor

Fixes Issue

**My PR closes #519 **

πŸ‘¨β€πŸ’» Changes proposed(What did you do ?)

  • Fixed the issue of stretching and misalignment of the 'include thumb radius' and 'include track radius' options in mobile view for chromium based browsers.

βœ”οΈ Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • This PR does not contain plagiarized content.
  • The title and description of the PR is clear and explains the approach.

Note to reviewers

πŸ“· Screenshots

image

@vercel
Copy link

vercel bot commented Oct 21, 2023

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
code-magic βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Oct 22, 2023 9:22am

@viditagrawal56
Copy link
Contributor Author

viditagrawal56 commented Oct 22, 2023

@Dun-sin when the screen size < 1000 px the width of the checkbox suddenly becomes half of the original width, and I can't find why it does that. Also you said that you don't see the issue on Firefox, but I faced this issue on Firefox too. So I just doubled the width of the checkbox in the media query of max-width 1000.

Let me know if you need any changes.

@Dun-sin
Copy link
Owner

Dun-sin commented Oct 22, 2023

your PR makes it worse on firefox:
image

@viditagrawal56
Copy link
Contributor Author

@Dun-sin That's really weird. Because for me on Firefox it resolves the issue.
I have attached Screen shots below.

Desktop view on Firefox :-
image

Mobile view on Firefox :-
image

@viditagrawal56
Copy link
Contributor Author

@Dun-sin Works even in the deployment preview

image

@viditagrawal56
Copy link
Contributor Author

@Dun-sin I found a new fix. I set the flex-shrink to 0 and it seems to fix the issue. Can you please check on your browser?

@Dun-sin
Copy link
Owner

Dun-sin commented Oct 22, 2023

@Dun-sin I found a new fix. I set the flex-shrink to 0 and it seems to fix the issue. Can you please check on your browser?

@viditagrawal56 it works now

Copy link
Owner

@Dun-sin Dun-sin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You did great, thanks for contributing, I hope you will stick around and continue to contribute to this project.

Consider giving this project a star and joining the community discord server if you haven't for more resources and opportunities to connect with others. πŸ‘‰πŸ½hereπŸ‘ˆπŸ½

@Dun-sin Dun-sin merged commit 076573e into Dun-sin:main Oct 22, 2023
@Dun-sin
Copy link
Owner

Dun-sin commented Oct 22, 2023

πŸŽ‰ This PR is included in version 2.72.3 πŸŽ‰

The release is available on GitHub release

Your semantic-release bot πŸ“¦πŸš€

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] The thumb radius section in Input Range breaks in mobile view.

2 participants