Skip to content

feat: support chaincall for handle error #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Dup4 merged 2 commits into from
Jul 2, 2023
Merged

feat: support chaincall for handle error #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3b0fa7d
feat: support chaincall for handle error
Dup4 Jul 2, 2023
19743fc
fix: return value
Dup4 Jul 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions include/result/result.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,17 +143,21 @@ class Result {
}

template <typename F>
void NotOKThen(F&& f) {
R& NotOKThen(F&& f) {
if (IsOK()) {
return;
return static_cast<R&>(*this);
}

f(*this);

return static_cast<R&>(*this);
}

template <typename F>
void AlwaysThen(F&& f) {
R& AlwaysThen(F&& f) {
f(*this);

return static_cast<R&>(*this);
}

void PushHistory(const std::string& file_name, int32_t line) {
Expand Down
22 changes: 21 additions & 1 deletion test/result_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -384,7 +384,7 @@ TEST_F(ResultTest, smart_pointer_with_nullptr) {
}
}

TEST_F(ResultTest, NotOKThen) {
TEST_F(ResultTest, NotOKThenAndAlwaysThen) {
int flag = 0;

std::invoke([]() -> CustomResult {
Expand Down Expand Up @@ -418,6 +418,26 @@ TEST_F(ResultTest, NotOKThen) {
});

EXPECT_EQ(flag, 3);

{
int n_flag = 0;
int a_flag = 0;

std::invoke([]() -> CustomResult {
return CustomResult::Builder(CustomResult::ErrorCode::OtherError).Build();
})
.NotOKThen([&n_flag](auto&& res) {
EXPECT_FALSE(res.IsOK());
n_flag = 1;
})
.AlwaysThen([&a_flag](auto&& res) {
EXPECT_FALSE(res.IsOK());
a_flag = 1;
});

EXPECT_EQ(n_flag, 1);
EXPECT_EQ(a_flag, 1);
}
}

TEST_F(ResultTest, GetHistoryInfoNode) {
Expand Down