Skip to content

refactor: Use bitflag for node state#281

Merged
CathalMullan merged 2 commits intomainfrom
bitflag
Mar 29, 2026
Merged

refactor: Use bitflag for node state#281
CathalMullan merged 2 commits intomainfrom
bitflag

Conversation

@CathalMullan
Copy link
Copy Markdown
Contributor

  • chore: Update dependencies
  • refactor: Use bitflag for node state

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 29, 2026

Codecov Report

❌ Patch coverage is 96.93878% with 3 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/node/delete.rs 83.33% 0 Missing and 2 partials ⚠️
src/parser.rs 93.75% 1 Missing ⚠️
Files with missing lines Coverage Δ
src/node.rs 100.00% <100.00%> (ø)
src/node/find.rs 92.00% <100.00%> (ø)
src/node/flags.rs 100.00% <100.00%> (ø)
src/node/insert.rs 100.00% <100.00%> (ø)
src/node/optimize.rs 100.00% <100.00%> (ø)
src/node/search.rs 95.33% <100.00%> (ø)
src/router.rs 87.32% <100.00%> (ø)
src/state.rs 100.00% <100.00%> (ø)
src/parser.rs 98.12% <93.75%> (+0.03%) ⬆️
src/node/delete.rs 93.40% <83.33%> (+0.14%) ⬆️

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Mar 29, 2026

Merging this PR will degrade performance by 11.09%

⚡ 11 improved benchmarks
❌ 32 (👁 32) regressed benchmarks
✅ 145 untouched benchmarks

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Memory gitlab_insert 2.5 MB 2.4 MB +4.43%
Simulation gitlab_delete 7.4 ms 6.8 ms +8.37%
👁 Simulation dynamic_inline[100] 70.1 µs 73.1 µs -4.14%
Simulation dynamic_inline[1] 1.9 µs 1.8 µs +4.85%
👁 Simulation dynamic_inline[1000] 665.8 µs 691.2 µs -3.67%
👁 Simulation wildcard_anchored[1000] 3.2 µs 3.4 µs -4.33%
👁 Simulation wildcard_anchored[10] 3.2 µs 3.3 µs -3.55%
👁 Simulation wildcard_anchored[100] 3.2 µs 3.3 µs -4.36%
Simulation dynamic_inline[10] 12 µs 10.9 µs +10.39%
👁 Simulation dynamic_depth[1000] 1.7 µs 1.8 µs -4.85%
👁 Simulation dynamic_depth[10] 1.7 µs 1.7 µs -3.34%
👁 Simulation dynamic_competing[10] 2.1 µs 2.2 µs -4.14%
Simulation wildcard_anchored[1] 520.3 ns 432.8 ns +20.22%
👁 Simulation wildcard_backtrack[1000] 1.5 µs 1.6 µs -9.08%
👁 Simulation wildcard_depth[100] 1.5 µs 1.6 µs -5.67%
👁 Simulation wildcard_backtrack[100] 1.5 µs 1.6 µs -7.4%
Simulation wildcard_chain[10] 12.6 µs 11.8 µs +7.03%
👁 Simulation wildcard_endings[1000] 1.7 µs 1.7 µs -3.37%
👁 Simulation wildcard_depth[1000] 1.5 µs 1.6 µs -5.67%
👁 Simulation wildcard_depth[10] 1.4 µs 1.6 µs -9.42%
... ... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.


Comparing bitflag (a86fd59) with main (0780318)

Open in CodSpeed

@CathalMullan CathalMullan merged commit d4b658a into main Mar 29, 2026
15 of 16 checks passed
@CathalMullan CathalMullan deleted the bitflag branch March 29, 2026 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant