Skip to content

feat: Introduce builder for router#282

Merged
CathalMullan merged 4 commits intomainfrom
builder
Mar 29, 2026
Merged

feat: Introduce builder for router#282
CathalMullan merged 4 commits intomainfrom
builder

Conversation

@CathalMullan
Copy link
Copy Markdown
Contributor

@CathalMullan CathalMullan commented Mar 29, 2026

  • refactor: Remove delete functionality
  • feat: Introduce builder for router
  • refactor: Remove get functionality
  • refactor: Inline data into nodes

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 29, 2026

Codecov Report

❌ Patch coverage is 92.68293% with 3 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/router.rs 75.00% 2 Missing ⚠️
src/node/display.rs 66.66% 0 Missing and 1 partial ⚠️
Files with missing lines Coverage Δ
src/node.rs 100.00% <ø> (ø)
src/node/conflict.rs 93.33% <100.00%> (ø)
src/node/insert.rs 100.00% <100.00%> (ø)
src/node/optimize.rs 99.42% <100.00%> (-0.58%) ⬇️
src/node/search.rs 95.33% <100.00%> (ø)
src/state.rs 100.00% <100.00%> (ø)
src/node/display.rs 81.39% <66.66%> (ø)
src/router.rs 93.18% <75.00%> (+5.85%) ⬆️

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Mar 29, 2026

Merging this PR will degrade performance by 8.86%

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 22 improved benchmarks
❌ 5 (👁 5) regressed benchmarks
✅ 159 untouched benchmarks
⏩ 2 skipped benchmarks1

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation gitlab_insert 900.9 ms 11.2 ms ×81
Simulation dynamic_inline[1] 1.8 µs 1.8 µs +3.6%
Simulation dynamic_competing[10] 2.2 µs 2.1 µs +4.6%
👁 Simulation dynamic_inline[10] 10.9 µs 12 µs -8.86%
Simulation wildcard_anchored[1000] 3.4 µs 3.2 µs +5.71%
Simulation dynamic_depth[100] 1.8 µs 1.7 µs +3.73%
Simulation dynamic_depth[1] 401.9 ns 335.3 ns +19.88%
Simulation wildcard_anchored[1] 432.8 ns 395.3 ns +9.49%
Simulation wildcard_anchored[10] 3.3 µs 3.2 µs +3.92%
👁 Simulation wayfind_parameters 88.4 µs 92 µs -3.93%
Simulation wildcard_backtrack[10] 1.6 µs 1.5 µs +4.24%
Simulation wildcard_backtrack[1000] 1.6 µs 1.5 µs +6.16%
Simulation wildcard_backtrack[1] 372.8 ns 335.3 ns +11.18%
Simulation wildcard_competing[1] 1.6 µs 1.5 µs +4.16%
👁 Simulation wildcard_chain[10] 11.8 µs 12.3 µs -4.63%
Simulation wildcard_chain[1] 2.5 µs 2.4 µs +7.73%
Simulation wildcard_competing[1000] 243.9 µs 235.9 µs +3.37%
Simulation wildcard_endings[100] 1.7 µs 1.7 µs +3.76%
Simulation wildcard_depth[100] 1.6 µs 1.5 µs +4.33%
Simulation wildcard_nested_inline[1] 403.6 ns 336.9 ns +19.79%
... ... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.


Comparing builder (f9d0d6b) with main (d4b658a)

Open in CodSpeed

Footnotes

  1. 2 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@CathalMullan CathalMullan merged commit eb9acd8 into main Mar 29, 2026
8 of 9 checks passed
@CathalMullan CathalMullan deleted the builder branch March 29, 2026 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant