build multi-arch java base docker images on gha#6
Merged
Merged
Conversation
git add everything build jdk and jre in parallel .github add shell skip make check spell TEMURIN tag interpolate images add arg to dockerfile add subdir to git context singular image conditional java.security paths for java 11 cleanup
staskolauren
requested review from
aquilesg,
beehivewarrior,
bpholt,
calebwsutton,
coreyjonoliver and
tylernap
bpholt
reviewed
Apr 13, 2022
| MAINTAINER Dwolla Engineering <dev+docker@dwolla.com> | ||
| LABEL org.label-schema.vcs-url="https://github.com/Dwolla/docker-java" | ||
|
|
||
| RUN if [ "$TEMURIN_TAG" = "8u322-b06-jdk" ] ; then \ |
Member
There was a problem hiding this comment.
This is clever! How difficult would it be to have it check whether "$TEMURIN_TAG" starts with 8u instead of doing a full string match, so we don't have to worry about updating this whenever the tag is updated?
bpholt
reviewed
Apr 13, 2022
bpholt
reviewed
Apr 13, 2022
|
|
||
| name: Build | ||
| description: Build and push docker images with Docker Buildx | ||
| inputs: |
Member
There was a problem hiding this comment.
This parameterization is awesome, nice work!
Contributor
Author
|
After some discussion with @bpholt -I refactored this PR to use one dockerfile, because we are performing the same ops on JDK/JRE images. That way we do not have to maintain separate dockerfiles for JDK vs JRE (unless we need to break them out again later). |
make check bash shell indentation Makefile updates
Contributor
Author
|
Thank you for the re-review @bpholt ! 🙏 I make those Makefile updates you suggested, so I think this is ready for re-review round three! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
8u322-b06-jreinstead of8-jre)