check if file exists, do not rely on TEMURIN_TAG#7
Merged
Conversation
exit if java.security path not found
staskolauren
requested review from
beehivewarrior,
bpholt,
calebwsutton,
coreyjonoliver and
tylernap
staskolauren
force-pushed
the
cleanup-dockerfile
branch
from
d6d2d57 to
8889dc8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Full credit goes to @bpholt for this idea:
Check if the
java.securityfile exists in a given path, and if so use that file path. If path is not one of the three known paths, exit with error "java.security file path not found".Functionality is maintained, but the Dockerfile no longer has knowledge of/responsibility for "valid"
TEMURIN_TAGvalues.