Skip to content

Conversation

@marcsous
Copy link
Contributor

…faster file creation on some platforms, fixed complex assign bug... plus some whitespace changes...

…faster file creation on some platforms... plus some whitespace changes...
@marcsous
Copy link
Contributor Author

Sorry I made a mess of this pull request stuff. First time! I deleted my old fork and made new one (this is it).

@DylanMuir
Copy link
Owner

Hi @marcsous, I've incorporated nearly all the changes. I rewrote sum a bit. The only one I skipped was the fast allocation of the temporary file using fallocate. The problem is, fallocate doesn't zero the file, so you end up with a bunch of garbage data in your new matrix. I couldn't decide whether that was reasonable or not.

@DylanMuir DylanMuir closed this Apr 24, 2016
DylanMuir added a commit that referenced this pull request May 25, 2016
9e73c53 * Added a flag to force `TIFFStack` to use slower `tiffread` library, if desired * Fixed a bug where linear indexing would not be range checked as early as possible * Fixed a bug in `tiffread` support * Improved unit testing to only require a [3x3x3] stack * Added unit tests for empty subreferences * Added unit tests for slower `tiffread` library support
cc5539f Documentation fix. Added `.gitignore` to repository
f77a0d4 Merge pull request #3 from jennan/pr/2
4768eea Fixed bug with deinterleaving + permutation + slicing
6ddc0d9 Added documentation regarding the de-interleaving functionality.
2ae0dd5 * Renamed de-interleaving argument * Improved parameter checking for de-interleaving argument * Re-allowed de-interleaving argument to leave off final frames, similar to `reshape`
f011b6f Bugfixes and improvements related to de-interleaving
e692bef Merge branch 'master' into pr/2
a32b839 Unit test now includes logical indexing
7a8a065 Merge branch 'master' into pr/2
356d33a * Added a unit testing function for `TIFFStack` * Added property accessor methods to `TIFFStack`, since otherwise properties were inaccessible * Fixed a bug when referencing inverted stacks with multiple samples per pixel * Fixed a referencing bug, where out of range subscripts would not raise an error, if fewer dimensions than the total were referenced * Modified an error identifier
36ad2ad Add special case with colon indexing of reinterpreted frame dimension
69e1360 Fix consistency in error style (CamelCase)
3251086 Move deinterleaving in the constructor, fixed for a TIFFStack
db994c7 Add deinterleaving method to reinterpret the frame dim as several dims
65c1a85 Fixed a referencing bug in `TIFFStack`
7362e2c Speed improvements to `TIFFStack`
92e4244 Fixed bugs relating to data returned by linear indexing having a different shape to the index vector.
1742646 Fixed a bug in `TIFFStack`, when referencing a stack with trailing dimensions of `1`
ce7e820 * `TIFFStack` can now read an entire stack in an accelerated fashion, with any number of referencing dimensions
a6abdfe Fixed a bug in `TIFFStack`, which caused a warning "Closing open TIFF file handle..." when clearing variables.
07bd9d5 Fixed a bug in `TIFFStack` on older systems, where referencing frame 1 of the stack would fail.
6504550 Made `fhCastFunction` a private `TIFFStack` property
13fa2f9 Added information to `TIFFStack` about disabling `tifflib` warnings.
e940e75 Fixed a bug in `TIFFStack`, where if the stack data class was an integer type, then stack data inversion would fail with an error.
ae27a64 `TIFFStack` now supports logical indexing.

git-subtree-dir: @tiffstack
git-subtree-split: 9e73c533a09782ad7f103157e02a0f5b40120806
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants