Fix NPE in HugeMushroomSpecies#rot (Closes #47)#48
Merged
supermassimo merged 1 commit intoDynamicTreesTeam:develop/1.21.1from Mar 1, 2026
Merged
Fix NPE in HugeMushroomSpecies#rot (Closes #47)#48supermassimo merged 1 commit intoDynamicTreesTeam:develop/1.21.1from
supermassimo merged 1 commit intoDynamicTreesTeam:develop/1.21.1from
Conversation
Prevent a NullPointerException during worldgen by safely handling a nullable return from Services.CONFIG.getIntConfig(MAX_BRANCH_ROT_RADIUS). Replaced unsafe auto-unboxing with an explicit null check and default value (0), ensuring stable feature placement when the config entry is missing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves #47 by preventing a
NullPointerExceptionduring world generation inHugeMushroomSpecies#rot.Services.CONFIG.getIntConfig(MAX_BRANCH_ROT_RADIUS)may returnnullif the config entry is missing or not initialized. The previous implementation relied on implicit unboxing, which caused a crash during feature placement.This change replaces unsafe auto-unboxing with an explicit null check and a safe default value of 0, ensuring worldgen remains stable even when the config entry is absent.
Impact
Closes #47.