-
Notifications
You must be signed in to change notification settings - Fork 5
DYN-8121 SplashScreen Disable Close Button #81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DYN-8121 SplashScreen Disable Close Button #81
Conversation
Remove all the code related to Close Button in SplashScreen
|
Rerunning the PR build step |
|
@RobertGlobant20 Somehow the first PR check failed again, can you double check? |
Updating the playwright/test package to 1.49.0
bumping : zgosalvez/github-actions-report-lcov action to v2 just to see if now it passes.
bumping : zgosalvez/github-actions-report-lcov action to v3 just to see if now it passes.
adding more code for the github action zgosalvez/github-actions-report-lcov@v3
removing lcov data
This reverts commit 5b03d4b.
bumping up version
- update action versions - add step to setup lcov
@QilongTang finally all the check passed (I had to update playwright/test to 1.49.0, also update the build github action otherwise the CodeCoverage was failing). |
|
Thanks @RobertGlobant20 Would you bump up the package version for splash screen so that we could have a new release and published as npm package? |
bumping up version from 1.0.26 to 1.0.27
@QilongTang version bumped up in the next commit: 540a849 |

Purpose
Remove all the code related to Close Button in SplashScreen.
TODO - Remove not needed code in Dynamo solution, I will submit a PR soon
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Remove all the code related to Close Button in SplashScreen
Reviewers
@QilongTang
FYIs