Skip to content

Conversation

@RobertGlobant20
Copy link
Contributor

Purpose

Remove all the code related to Close Button in SplashScreen.
TODO - Remove not needed code in Dynamo solution, I will submit a PR soon

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

Remove all the code related to Close Button in SplashScreen

Reviewers

@QilongTang

FYIs

Remove all the code related to Close Button in SplashScreen
@RobertGlobant20
Copy link
Contributor Author

GIF showing the expected behavior in Dynamo.
devenv_HuAEDfocj1

@QilongTang
Copy link
Contributor

Rerunning the PR build step

@QilongTang
Copy link
Contributor

@RobertGlobant20 Somehow the first PR check failed again, can you double check?

Updating the playwright/test package to 1.49.0
bumping : zgosalvez/github-actions-report-lcov action to v2 just to see if now it passes.
bumping : zgosalvez/github-actions-report-lcov action to v3 just to see if now it passes.
adding more code for the github action zgosalvez/github-actions-report-lcov@v3
removing lcov data
bumping up version
- update action versions
- add step to setup lcov
@RobertGlobant20
Copy link
Contributor Author

@RobertGlobant20 Somehow the first PR check failed again, can you double check?

@QilongTang finally all the check passed (I had to update playwright/test to 1.49.0, also update the build github action otherwise the CodeCoverage was failing).
Thanks @avidit for the help

@QilongTang
Copy link
Contributor

Thanks @RobertGlobant20 Would you bump up the package version for splash screen so that we could have a new release and published as npm package?

bumping up version from 1.0.26 to 1.0.27
@RobertGlobant20
Copy link
Contributor Author

Thanks @RobertGlobant20 Would you bump up the package version for splash screen so that we could have a new release and published as npm package?

@QilongTang version bumped up in the next commit: 540a849

@QilongTang QilongTang merged commit b73c1a5 into DynamoDS:master Jan 27, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants